added emails and tests #93

Tycho-van-den-Heuvel · 2026-06-17T13:36:12+02:00

Tycho-van-den-Heuvel commented

2026-06-17 13:36:12 +02:00

If you create servicelogs through the api. no emails are sent. This PR adds that feature.

When creating a servicelog through the CRM it only sends an email if it's a new servicelog. I wanted to keep this property in the api as well.

When submitting a checklist we don't want to send an email since it will flood the email even more because submitting checklists will be more frequent

If you create servicelogs through the api. no emails are sent. This PR adds that feature. When creating a servicelog through the CRM it only sends an email if it's a new servicelog. I wanted to keep this property in the api as well. When submitting a checklist we don't want to send an email since it will flood the email even more because submitting checklists will be more frequent

Tycho-van-den-Heuvel added 1 commit

2026-06-17 13:36:13 +02:00

added emails and tests

Verify Pull Request / tests (pull_request) Successful in 1m50s

Details

1062ded229

Luke-Watts reviewed

2026-06-18 20:14:40 +02:00

api/views.py

					
				@ -205,0 +206,4 @@

				        # don't bother participants with checklists emails

				        if (

				            servicelog.situation != Servicelog.MSC_UNCHECKED_TODO and self.request.POST

Rather than checking its not Servicelog.MSC_UNCHECKED_TODO, can we use an allowlist of events which should trigger an email?>

Rather than checking its not `Servicelog.MSC_UNCHECKED_TODO`, can we use an allowlist of events which should trigger an email?>

Verify Pull Request / tests (pull_request) Successful in 1m50s

Required

Details

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u feat/emails-when-creating-servicelogs-through-api:Tycho-van-den-Heuvel-feat/emails-when-creating-servicelogs-through-api

git switch Tycho-van-den-Heuvel-feat/emails-when-creating-servicelogs-through-api

Sign in to join this conversation.

No reviewers

No labels

Draft

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

msl/intranet!93

Rows
Columns