feat/add-reporter-name-to-servicelog #79

Tycho-van-den-Heuvel · 2026-06-04T09:48:04+02:00

Tycho-van-den-Heuvel commented

2026-06-04 09:48:04 +02:00

Added reporter name to limit the amount of api request our application has to make to the CRM

Tycho-van-den-Heuvel added 2 commits

2026-06-04 09:48:05 +02:00

added reporter name 5774f0e7e6

added tests for reporter name

Verify Pull Request / tests (pull_request) Successful in 1m33s

Details

eda8fc6bda

Dirk-Willem-van-Gulik approved these changes

2026-06-04 11:09:12 +02:00

Dirk-Willem-van-Gulik left a comment

passes munster

api/serializers.py

					
				@ -150,6 +161,18 @@ class ServicelogSerializer(serializers.ModelSerializer):

				            return image.url

				        return None

				    def get_reporter_first_name(self, obj):

Fine to do this - and can help make things cleaner. But know that in django (and simular frameworks) you do not actually have to do this - object.reported. generally magically returns that field as if there was a get()er. ignoring the get_reporting() getting in the way.

Fine to do this - and can help make things cleaner. But know that in django (and simular frameworks) you do not actually have to do this - object.reported.<fieldname> generally magically returns that field as if there was a get()er. ignoring the get_reporting() getting in the way.